content(styles): replace lorem ipsum with fact-checked CAMRA style descriptions - #238
Merged
Merged
Conversation
…scriptions Replaces all 29 lorem ipsum beer style placeholders in assets/style_descriptions.json with accurate descriptions validated against CAMRA and BJCP guidelines. Key corrections applied during fact-checking: - Brown ale: Northern Brown (Newcastle) is paler than Southern Brown, not darker - Scotch ale: clarified smoke comes from roasted malt, not peat - Hefeweizen/Weissbier: noted these are regional names for the same style - Bock: corrected ABV floor to ~6.3%, added pale Maibock variant - Porter: qualified the 'lighter than Stout' framing as a modern distinction - Mild: removed disputed 'oldest style' claim - Saison: added context that historical versions were very low ABV Updates golden screenshots and test assertions to match real content. Adds 'speciality' entry not previously in the JSON. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Replaces placeholder (lorem ipsum) style descriptions with real, fact-checked CAMRA/BJCP-aligned content, and updates tests/docs to reflect the longer, real-world copy.
Changes:
- Updated
assets/style_descriptions.jsonwith accurate descriptions for existing styles and added a missingspecialityentry. - Adjusted widget tests to accommodate longer description text (larger surface size in a few cases) and updated assertions away from lorem ipsum.
- Added documentation guidance in
CLAUDE.mdon capturing test output once and grepping it efficiently.
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/style_screen_test.dart | Enlarges test viewport for cases where longer descriptions push drink cards below the initial viewport; updates assertions to match real IPA description text. |
| test/style_description_helper_test.dart | Updates assertions to validate real description content instead of lorem ipsum placeholders. |
| CLAUDE.md | Adds a workflow note for running tests once and grepping captured output rather than repeatedly re-running tests. |
| assets/style_descriptions.json | Replaces placeholder text with fact-checked style descriptions and adds the speciality description entry. |
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…descriptions The ui-refresh-2026 merge introduced new card accent bars. Goldens now reflect both the updated theme and the real CAMRA style descriptions. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
🚀 Cloudflare Pages PreviewYour preview deployment is ready! Preview URL: https://worktree-update-beer-style-d.staging-cambeerfestival.pages.dev This preview will be automatically updated when you push new commits to this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
assets/style_descriptions.jsonwith accurate descriptions validated against CAMRA and BJCP guidelinesspecialityentryTest Plan
./bin/mise run test)